linux-kernel - Re: [PATCH] staging: skein: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Dec 2014 10:06:22 -0800
From:	Joe Perches <joe@...ches.com>
To:	arno.tiemersma@...il.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: skein: Fix checkpatch warnings

On Thu, 2014-12-25 at 19:01 +0100, arno.tiemersma@...il.com wrote:
> Remove do {} while (0) loops around single statements in
> skein/skein_block.c
[]
> diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
[]
> @@ -83,9 +83,7 @@ do {                                                                      \
>  #else
>  /* looping version */
>  #define R256(p0, p1, p2, p3, ROT, r_num) \
> -do { \
>  	ROUND256(p0, p1, p2, p3, ROT, r_num); \

When you do these things, you also have to
remove the trailing semi-colon and the
line continuation '\' as well.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/