linux-kernel - Re: [PATCH v1] staging: comedi: dmm32at: fix style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141225110444.GA30022@newt.localdomain>
Date:	Thu, 25 Dec 2014 03:04:44 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	David Decotigny <ddecotig@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Ian Abbott <abbotti@....co.uk>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
Subject: Re: [PATCH v1] staging: comedi: dmm32at: fix style issues

David,

On Wed, Dec 24, 2014 at 05:55:38PM -0800, David Decotigny wrote:
> Before:
>       1 ERROR: code indent should use tabs where possible
>       1 WARNING: please, no spaces at the start of a line
> 
> After:
>   (none)
> 
> Signed-off-by: David Decotigny <ddecotig@...il.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..1615103 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>  	outb(hi2, dev->iobase + DMM32AT_CLK2);
>  
>  	/* enable the ai conversion interrupt and the clock to start scans */
> -	outb(DMM32AT_INTCLK_ADINT |
> -	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN |
> +		 DMM32AT_INTCLK_CLKSEL,
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>  }
>  
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

Your patch re-formats this section, but I don't think this is needed.
Some people like to format their code so it is aligned at the left
parenthesis.

The warning is about the line which is indented entirely using spaces
and no tabs.  The following patch would fix the warning without
disrupting the formatting.

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..31919b8 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	/* enable the ai conversion interrupt and the clock to start scans */
 	outb(DMM32AT_INTCLK_ADINT |
 	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/