linux-kernel - Re: [PATCH] x86: Fix multiple coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141226142946.GA28213@newt.localdomain>
Date:	Fri, 26 Dec 2014 06:29:46 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Fix multiple coding style issues

Alexander,

On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:

Your description needs to be more specific than just "coding style
fixes".  What type of problems did you fix?  How did you find them?

(more inline...)

> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/boot/header.S | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S
> index 16ef025..75f016b 100644
> --- a/arch/x86/boot/header.S
> +++ b/arch/x86/boot/header.S
> @@ -211,7 +211,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x60500020			# Characteristics (section flags)
> +	.long	0x60500020			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The EFI application loader requires a relocation section
> @@ -229,7 +230,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x42100040			# Characteristics (section flags)
> +	.long	0x42100040			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The offset & size fields are filled in by build.c.
> @@ -247,7 +249,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0x60500020			# Characteristics (section flags)
> +	.long	0x60500020			# Characteristics
> +						# (section flags)
>  
>  	#
>  	# The offset & size fields are filled in by build.c.
> @@ -266,7 +269,8 @@ section_table:
>  	.long	0				# PointerToLineNumbers
>  	.word	0				# NumberOfRelocations
>  	.word	0				# NumberOfLineNumbers
> -	.long	0xc8000080			# Characteristics (section flags)
> +	.long	0xc8000080			# Characteristics
> +						# (section flags)
>  
>  #endif /* CONFIG_EFI_STUB */
>  
> @@ -426,7 +430,8 @@ cmdline_size:   .long   COMMAND_LINE_SIZE-1     #length of the command line,
>                                                  #added with boot protocol
>                                                  #version 2.06
>  
> -hardware_subarch:	.long 0			# subarchitecture, added with 2.07
> +hardware_subarch:	.long 0			# subarchitecture,
> +						# added with 2.07
>  						# default to 0 for normal x86 PC
>  
>  hardware_subarch_data:	.quad 0
> -- 
> 2.2.1.202.g98acd41
> 

It looks like your fixes are for lines being over 80 characters.  While
it is preferrable that lines be less than 80 characters it is still
acceptable if they are longer.

If you are looking for things to fix I suggest looking in the
drivers/staging directory.  There are lots of things that need to be
fixed in there.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/