linux-kernel - Re: [PATCH] x86: Fix multiple coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141226180206.GA3449@hudson.localdomain>
Date:	Fri, 26 Dec 2014 10:02:06 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Fix multiple coding style issues

Alexander,

On Fri, Dec 26, 2014 at 11:09:53PM +0600, Alexander Kuleshov wrote:
> Hello Jeremiah,
> 
> Thank you for feedback. It is my first patches to kernel, so i have a
> some little questions:
> 
I recommend checking out Greg Kroah Hartman's presentation on submitting
your first patch.  It has lots of good tips.

https://www.youtube.com/watch?v=LLBrBBImJt4

> > Jeremiah Mahler <jmmahler@...il.com>:
> > Alexander,
> >
> > On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
> >
> > Your description needs to be more specific than just "coding style
> > fixes".  What type of problems did you fix?  How did you find them?
> >
> 
> There are some lines which more than 80 chars, I found it with
> scripts/checkpatch.pl.
> What is the best place to put this description? In commit message
> after first line?
> 

Yes, just put that in the log message.  The first line is the summary,
then a blank line, then the detailed log message.  The summary line is
what ends up in the subject line of the email.

> > Jeremiah Mahler <jmmahler@...il.com>:
> > If you are looking for things to fix I suggest looking in the
> > drivers/staging directory.  There are lots of things that need to be
> > fixed in there.
> 
> So i must make this patch for kernel/git/gregkh/staging.git and resend
> it again or just to add to this thread?
> Or i'm wrong?
> 
You figured this out in your next message :)

> Thank you.

Glad I could help :)
-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/