linux-kernel - Re: [PATCH] move exit_task_work() before exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141226193028.GE22149@ZenIV.linux.org.uk>
Date:	Fri, 26 Dec 2014 19:30:28 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Leon Ma <xindong.ma@...el.com>
Cc:	akpm@...ux-foundation.org, oleg@...hat.com, mhocko@...e.cz,
	mingo@...nel.org, peterz@...radead.org, riel@...hat.com,
	ionut.m.alexa@...il.com, peter@...leysoftware.com,
	linux-kernel@...r.kernel.org, di.zhang@...el.com,
	zhonghua.sun@...el.com
Subject: Re: [PATCH] move exit_task_work() before exit_fs().

On Fri, Dec 26, 2014 at 03:45:25PM +0800, Leon Ma wrote:
> We encountered following panic. The scenario is the process is exiting and executing its
> task work. When closing dev node, the driver triggers a firmware reload according to device
> status. Because task->fs is set to NULL in exit_fs(), panic happens.
> Task work is a common interface, we should not limite the resource the user will utilize.

Fix your driver.  Forget ->fs being NULL; what will happen if your process
is chrooted?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/