linux-kernel - Re: [PATCH 05/37] perf tools: Create separate mmap for dummy tracking event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjOkCXAMa-2bWmtZmMinuC3_N4DtN9LO6Nx+poggggaZw@mail.gmail.com>
Date:	Fri, 26 Dec 2014 10:45:27 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <andi@...stfloor.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 05/37] perf tools: Create separate mmap for dummy tracking event

On Fri, Dec 26, 2014 at 7:08 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Wed, Dec 24, 2014 at 04:15:01PM +0900, Namhyung Kim wrote:
>> When multi file support is enabled, a dummy tracking event will be
>> used to track metadata (like task, comm and mmap events) for a session
>> and actual samples will be recorded in separate files.
>>
>> Provide separate mmap to the dummy tracking event.  The size is fixed
>> to 128KiB (+ 1 page) as the event rate will be lower than samples.  I
>> originally wanted to use a single mmap for this but cross-cpu sharing
>> is prohibited so it's per-cpu (or per-task) like normal mmaps.
>
> maybe this needs to be applied after next patch?
>   perf tools: Introduce perf_evlist__mmap_multi

Oops, sorry.  it seems the code was mixed after huge number of
rebase..  The commit order is right but it just has a wrong hunk.


>
> I'm getting compile error:
>
> [jolsa@...va perf]$ make JOBS=1
>   BUILD:   Doing 'make -j1' parallel build
>   CC       util/evlist.o
> util/evlist.c: In function ‘perf_evlist__mmap_per_evsel’:
> util/evlist.c:937:9: error: ‘struct mmap_params’ has no member named ‘track’
>    if (mp->track && perf_evsel__is_dummy_tracking(evsel)) {
>          ^
> util/evlist.c: In function ‘perf_evlist__mmap’:
> util/evlist.c:1092:62: error: ‘use_track_mmap’ undeclared (first use in this function)
>   if (evlist->mmap == NULL && perf_evlist__alloc_mmap(evlist, use_track_mmap) < 0)
>                                                               ^
> util/evlist.c:1092:62: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [util/evlist.o] Error 1
> make: *** [all] Error 2

Will fix, thanks
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/