linux-kernel - Re: [PATCH v2] bcma: Fix three coding style issues, more than 80 characters per line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6rx4CPwzH0K9R3AtdXN8GbRcu-6VqXue7fFPh770WhR_aw@mail.gmail.com>
Date:	Fri, 26 Dec 2014 22:26:03 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Oscar Forner Martinez <oscar.forner.martinez@...il.com>
Cc:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] bcma: Fix three coding style issues, more than 80
 characters per line

On 26 December 2014 at 19:33, Oscar Forner Martinez
<oscar.forner.martinez@...il.com> wrote:
> -                       /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP clock */
> +                       /* 4706 CC and PMU watchdogs are clocked
> +                        * at 1/4 of ALP clock
> +                        */

Your editor seems to be treating tabs incorrectly. Like more than 8
chars. After your patch "clocked" ends after  64 chars. You should try
to use up to 80 chars.


> -               bcma_err(cc->core->bus, "serial not supported on this device ccrev: 0x%x\n", ccrev);
> +               bcma_err(cc->core->bus,
> +                        "serial not supported on this device ccrev: 0x%x\n",
> +                        ccrev);

I think you ignored my comment to V1, see it again please ;) It was
about putting pointer and string in one line.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/