linux-kernel - Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rxjrcpZXiv0jxmY4+EtLESYtKh=6W2RgqUDLHYy3AQ4rA@mail.gmail.com>
Date:	Sat, 27 Dec 2014 21:19:49 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Oscar Forner Martinez <oscar.forner.martinez@...il.com>
Cc:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bcma: fix three coding style issues, more than 80
 characters per line

On 27 December 2014 at 20:24, Oscar Forner Martinez
<oscar.forner.martinez@...il.com> wrote:
> Three lines with more than 80 characters per line have been split in several lines.

Thanks for the next version :)

1) You missed version number. Something like
git format-patch --subject-prefix="PATCH V3"
(you saying for the future).

2) I'm OK with your changes, but when checking the patch I get some errors like
ERROR: trailing whitespace
ERROR: DOS line endings
(I used ./scripts/checkpatch.pl, see attached checkpatch log).

I think that "trailing whitespace" errors are caused by DOS line
endings, because I don't see anything wrong about your code.

Is there something wrong with your emacs? git-send-email shouldn't
malform patches I believe.

View attachment "bcma.checkpatch.txt" of type "text/plain" (1123 bytes)