linux-kernel - Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUVuTB55UcKKbUMd8VB5mHMkaxhCVDkLKhtSXizR+1gE2A@mail.gmail.com>
Date:	Sun, 28 Dec 2014 10:12:19 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Oscar Forner Martinez <oscar.forner.martinez@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bcma: fix three coding style issues, more than 80
 characters per line

On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki <zajec5@...il.com> wrote:
> On 28 December 2014 at 06:50, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki <zajec5@...il.com> wrote:
>>> On 27 December 2014 at 20:24, Oscar Forner Martinez
>>> <oscar.forner.martinez@...il.com> wrote:
>>>> Three lines with more than 80 characters per line have been split in several lines.
>>>>
>>>> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@...il.com>
>>>
>>> Acked-by: Rafał Miłecki <zajec5@...il.com>
>>>
>>
>> As for the comment-line changes... 80+ chars are allowed for better readability.
>> So, please don't do that.
>> [ Checkpatch should not warn on this especially for comments. ]
>
> We almost always split long comments into separated lines in the
> kernel. What's different with this case?
>

1st it is not mandatory.

2nd it is more readable in one line.

-                       /* 4706 CC and PMU watchdogs are clocked at
1/4 of ALP clock */
+                       /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP
+                        * clock
+                        */

I agree with you when the comment would be longer.

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/