linux-kernel - [PATCH] Ensure different messages in STRICT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141228161524.GA10442@amd>
Date:	Sun, 28 Dec 2014 17:15:24 +0100
From:	Pavel Machek <pavel@....cz>
To:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: [PATCH] Ensure different messages in STRICT_DEVMEM and PAT cases

commit 823a62aebddaec01fd776a8dd4f8f4a5b419e3f9
Author: Pavel <pavel@....cz>
Date:   Sun Dec 28 17:04:02 2014 +0100

STRICT_DEVMEM and PAT produce same failure accessing /dev/mem, which
is quite confusing to the user. Make printk messages different to
lessen confusion.
    
Signed-off-by: Pavel Machek <pavel@....cz>

diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index 6574388..2b6f5d8 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -488,7 +488,7 @@ pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
 }
 
 #ifdef CONFIG_STRICT_DEVMEM
-/* This check is done in drivers/char/mem.c in case of STRICT_DEVMEM*/
+/* This check is done in drivers/char/mem.c in case of STRICT_DEVMEM */
 static inline int range_is_allowed(unsigned long pfn, unsigned long size)
 {
 	return 1;
@@ -506,7 +506,7 @@ static inline int range_is_allowed(unsigned long pfn, unsigned long size)
 
 	while (cursor < to) {
 		if (!devmem_is_allowed(pfn)) {
pp-			printk(KERN_INFO "Program %s tried to access /dev/mem between [mem %#010Lx-%#010Lx]\n",
+			printk(KERN_INFO "Program %s tried to access /dev/mem between [mem %#010Lx-%#010Lx], PAT prevents it\n",
 				current->comm, from, to - 1);
 			return 0;
 		}

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/