linux-kernel - Re: [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1419785144.20894.10.camel@perches.com>
Date:	Sun, 28 Dec 2014 08:45:44 -0800
From:	Joe Perches <joe@...ches.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org,
	Evgeniy Dushistov <dushistov@...l.ru>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fs/ufs/super.c: remove unnecessary casting

On Sun, 2014-12-28 at 15:33 +0000, Al Viro wrote:
> On Sun, Dec 28, 2014 at 04:28:29PM +0100, Fabian Frederick wrote:
> > Fix the following coccinelle warning:
> > fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory
> > allocation function to (struct ufs_inode_info *) is useless.
> 
> ... except that it makes allocations harder to grep for.

How does it do that?

> IOW, it's not
> obviously an improvement and should be up to maintainer of the code in
> question.

That's always true in any case.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/