linux-kernel - Re: rfc: remove early_printk from a few arches? (blackfin, m68k, mips)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 28 Dec 2014 19:36:25 +0100
From:	Pavel Machek <pavel@....cz>
To:	Måns Rullgård <mans@...sr.com>
Cc:	Joe Perches <joe@...ches.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-arch <linux-arch@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	Steven Miao <realmz6@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	linux-mips <linux-mips@...ux-mips.org>
Subject: Re: rfc: remove early_printk from a few arches? (blackfin, m68k,
 mips)

On Fri 2014-12-19 10:33:42, Måns Rullgård wrote:
> Joe Perches <joe@...ches.com> writes:
> 
> > On Fri, 2014-12-19 at 01:43 +0000, Måns Rullgård wrote:
> >> What exactly are you proposing to remove?
> >
> > Optionally compile out
> > kernel/printk/printk.c:early_printk()
> > even if CONFIG_EARLY_PRINTK is enabled.
> >
> >> I see no unused code related
> >> to early printk (in any variant) under arch/mips.
> >
> > I think there could be yet another CONFIG option
> > to specifically enable the early_printk function
> > for the arches that use it.
> 
> Why bother?  On MIPS it would save 132 bytes of compiled code.
> 
> > The kernel/printk/early_printk() function seems
> > used only by arm/microblaze/tile/x86.
> 
> Rather than introduce more config complexity, you could try to remove
> the 7 remaining uses of early_printk().
> 
> - arch/arm/mach-socfpga
>   Single early_printk("Early printk initialized\n") call serving no
>   apparent purpose can probably be safely deleted.  Since there are no
>   other early_printk() calls, this information seems rather useless.

Feel free to do that, but please keep early_printk() available...

...so that I can debug the socfpga early boot when needed.

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/