linux-kernel - Re: [PATCH 3/3] Staging: comedi: fix space and 80 char coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141229070712.GD3749@sudip-PC>
Date:	Mon, 29 Dec 2014 12:37:12 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	jitendra kumar khasdev <jkhasdev@...il.com>
Cc:	gregkh@...uxfoundation.org, abbotti@....co.uk,
	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	pankaj.saraf@...tech.in
Subject: Re: [PATCH 3/3] Staging: comedi: fix space and 80 char coding style
 issue

On Mon, Dec 29, 2014 at 03:14:45AM +0530, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up spcae and maximum
> character limit warning found by the checkpatch.pl tool

you are doing two different kind of changes in this patch. it should be in two different patches. One patch should do only one type of change.

thanks
sudip

> 
> Signed-off-by: Jitendra Kumar Khasdev  <jkhasdev@...il.com>
> ---
>  drivers/staging/comedi/drivers/s626.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index 14932c5..77f715b 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
>  static void s626_mc_disable(struct comedi_device *dev,
>  			    unsigned int cmd, unsigned int reg)
>  {
> -	writel(cmd << 16 , dev->mmio + reg);
> +	writel(cmd << 16, dev->mmio + reg);
>  	mmiowb();
>  }
>  
> @@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
>  	for (i = 0; i < 2; i++) {
>  		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
>  		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> -		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> +		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> +		0);
>  		if (ret)
>  			return ret;
>  	}
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/