linux-kernel - Re: [PATCH] powerpc/powernv: Select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1419843707.30395.5.camel@ellerman.id.au>
Date:	Mon, 29 Dec 2014 20:01:47 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	"Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>,
	Michael Neuling <mikey@...ling.org>,
	"open list:LINUX FOR POWERPC..." <linuxppc-dev@...ts.ozlabs.org>,
	open list <linux-kernel@...r.kernel.org>,
	hegdevasant@...ux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv: Select CONFIG_PRINTK to fix build
 failure

On Sat, 2014-12-27 at 12:17 -0500, Pranith Kumar wrote:
> In an allnoconfig we get the following build failure:
 
An allnoconfig doesn't include CONFIG_PPC_POWERNV? But I think I know what you
mean.

> arch/powerpc/platforms/built-in.o: In function `.__machine_initcall_powernv_opal_init':
> opal.c:(.init.text+0x468): undefined reference to `.log_buf_addr_get'
> opal.c:(.init.text+0x474): undefined reference to `.log_buf_len_get'
> make: *** [vmlinux] Error 1
> 
> This happens because powernv requires printk() support. Enable it in the config
> file.

Sort of. It just requires those two routines. Or is there a stronger
dependency?

I think the better fix is for those two routines to be defined for
CONFIG_PRINTK=n, but return NULL and zero respectively.

And the opal code could skip registering the region when they return NULL/zero.

Care to do a couple of patches?

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/