linux-kernel - Re: [PATCH] bfin_can: move the header file to arch independent location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54A17B83.60206@hartkopp.net>
Date:	Mon, 29 Dec 2014 17:04:19 +0100
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	"Wu, Aaron" <Aaron.Wu@...log.com>,
	"adi-buildroot-devel@...ts.sourceforge.net" 
	<adi-buildroot-devel@...ts.sourceforge.net>,
	"wg@...ndegger.com" <wg@...ndegger.com>,
	"mkl@...gutronix.de" <mkl@...gutronix.de>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bfin_can: move the header file to arch independent location

Hi Aaron,

On 12/29/2014 03:32 AM, Wu, Aaron wrote:
>> From: Oliver Hartkopp [mailto:socketcan@...tkopp.net]

>> So the correct way is to check which defines are *really* referenced and add
>> these directly to bfin_can.c (the only user) when removing bfin_can.h
> 
> Thanks for reply, will merge your idea and be back.

Great. As there's so many unused stuff in bfin_can.h I assume this to be a
real good improvement.

> Also your comments about another of my recent patch " Rewrite the blackfin CAN driver into arch independent style" is welcome.

This looks good to ME but usually Marc maintains the driver portions - and I
don't really know if it just *looks* good or if it *is* good ;-)

I just wanted to comment on the include file - as I knew the potential
feedback from Marc there. For the rest we need to wait for Marc coming back
from vacation.

Best regards,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/