linux-kernel - Re: [PATCH] bfin_can: move the header file to arch independent location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <54A19123.5040708@hartkopp.net>
Date:	Mon, 29 Dec 2014 18:36:35 +0100
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Heinz-Jürgen Oertel <hj.oertel@...nline.de>,
	mkl@...gutronix.de
CC:	Aaron Wu <Aaron.wu@...log.com>, linux-can@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bfin_can: move the header file to arch independent location

On 12/29/2014 05:45 PM, Heinz-Jürgen Oertel wrote:
> Am Samstag, 27. Dezember 2014, 12:09:30 schrieb Oliver Hartkopp:
>> As bfin_can.c is the only user of defines from this include file just add the
>> needed(!) defines directly to bfin_can.c
> 
> I often include also the yet unneeded definitions, e.g., for unused register or unused bit definitions.
> That makes it easier for someone else to add missing functionality, when later on needed.
> 

Yes. This can be useful when you can imagine to add functionality into a
specific direction. But in this case there were tons of mailbox definitions
(always defined 32 times each) which we will not use in this way in the netdev
driver.

Just take a look into bfin_can.h and what is really used in bfin_can.c from
those defines and you will see.

Regards,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/