lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Dec 2014 09:41:16 -0800 From: Jeremiah Mahler <jmmahler@...il.com> To: Jonas Lundqvist <jonas@...non.se> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Staging: line6: remove spaces before commas. Jonas, In your subject line, when you create a new version of a patch, include the version number. In this case it would be "[PATCH v2]". On Mon, Dec 29, 2014 at 04:34:18PM +0100, Jonas Lundqvist wrote: > Fixed three errors in pcm.h found by checkpatch.pl: > > drivers/staging/line6/pcm.h:148: ERROR: space prohibited before that ',' > (ctx:WxE) > drivers/staging/line6/pcm.h:155: ERROR: space prohibited before that ',' > (ctx:WxE) > drivers/staging/line6/pcm.h:162: ERROR: space prohibited before that ',' > (ctx:WxE) > It is better than no description at all. But listing each identical error is redundant. I would have just said something to the effect of "fix three space prohibited errors ...". > Signed-off-by: Jonas Lundqvist <jonas@...non.se> > --- > drivers/staging/line6/pcm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > [...] -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists