linux-kernel - Re: [PATCH v2] Staging: line6: remove spaces before commas.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141229223655.GA2210@hudson.localdomain>
Date:	Mon, 29 Dec 2014 14:36:55 -0800
From:	Jeremiah Mahler <jmmahler@...il.com>
To:	Jonas Lundqvist <jonas@...non.se>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: line6: remove spaces before commas.

Jonas,

On Mon, Dec 29, 2014 at 10:12:00PM +0100, Jonas Lundqvist wrote:
> Fix three space prohibited errors in pcm.h found by checkpatch.pl.
> 
That is a nice log message.  Clean and simple. :-)

> Signed-off-by: Jonas Lundqvist <jonas@...non.se>
> ---
>  drivers/staging/line6/pcm.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
> index 6aa0d46..5d87934 100644
> --- a/drivers/staging/line6/pcm.h
> +++ b/drivers/staging/line6/pcm.h
> @@ -145,21 +145,21 @@ enum {
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_BUFFER,
>  
>  	LINE6_BITS_PLAYBACK_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_PLAYBACK_STREAM |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_PLAYBACK_STREAM |
> -	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM ,
> +	    LINE6_BIT_PCM_MONITOR_PLAYBACK_STREAM,
>  
>  	LINE6_BITS_CAPTURE_BUFFER =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
>  	    LINE6_BIT_PCM_IMPULSE_CAPTURE_BUFFER |
>  #endif
>  	    LINE6_BIT_PCM_ALSA_CAPTURE_BUFFER |
> -	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER ,
> +	    LINE6_BIT_PCM_MONITOR_CAPTURE_BUFFER,
>  
>  	LINE6_BITS_CAPTURE_STREAM =
>  #ifdef CONFIG_LINE6_USB_IMPULSE_RESPONSE
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Looks good to me.

Reviewed-by: Jeremiah Mahler <jmmahler@...il.com>

-- 
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/