linux-kernel - Re: esp_scsi: make number of tags configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141230121428.GE32187@infradead.org>
Date:	Tue, 30 Dec 2014 04:14:28 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Hannes Reinecke <hare@...e.de>, Christoph Hellwig <hch@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	scsi <linux-scsi@...r.kernel.org>
Subject: Re: esp_scsi: make number of tags configurable

On Wed, Dec 10, 2014 at 11:16:47AM +0100, Geert Uytterhoeven wrote:
> > --- a/drivers/scsi/esp_scsi.c
> > +++ b/drivers/scsi/esp_scsi.c
> > @@ -2317,6 +2317,10 @@ int scsi_esp_register(struct esp *esp, struct device *dev)
> >         static int instance;
> >         int err;
> >
> > +       if (!esp->num_tags)
> > +               esp->num_tags = ESP_DEFAULT_TAGS;
> > +       else if (esp->num_tags >= ESP_MAX_TAG)
> 
> drivers/scsi/esp_scsi.c: In function ???scsi_esp_register???:
> drivers/scsi/esp_scsi.c:2399: warning: comparison is always false due
> to limited range of data type
> 
> ESP_MAX_TAG is 256, num_tags is u8.

Can you send me a patch to just remove that conditional?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/