lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Dec 2014 11:19:47 -0500 From: Nicholas Mc Guire <der.herr@...r.at> To: Nagalakshmi Nandigama <nagalakshmi.nandigama@...gotech.com> Cc: Praveen Krishnamoorthy <praveen.krishnamoorthy@...gotech.com>, Sreekanth Reddy <sreekanth.reddy@...gotech.com>, Abhijit Mahajan <abhijit.mahajan@...gotech.com>, "James E.J. Bottomley" <JBottomley@...allels.com>, Joe Lawrence <joe.lawrence@...atus.com>, MPT-FusionLinux.pdl@...gotech.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Nicholas Mc Guire <der.herr@...r.at> Subject: [SCSI] mpt2sas: wait_for_completion_timeout timeout not reported wait_for_completion_timeout reaching timeout was being ignored, this also should fail if timeout condition occurs. Thanks to Joe Lawrence <joe.lawrence@...atus.com> for confirmation. this was only compile tested with x86_64_defconfig + CONFIG_SCSI_LOWLEVEL=y + CONFIG_SCSI_MPT2SAS=m patch is against linux-next 3.19.0-rc1 -next-20141226 Signed-off-by: Nicholas Mc Guire <der.herr@...r.at> --- drivers/scsi/mpt2sas/mpt2sas_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_config.c b/drivers/scsi/mpt2sas/mpt2sas_config.c index c72a2ff..02dc2d8 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_config.c +++ b/drivers/scsi/mpt2sas/mpt2sas_config.c @@ -391,7 +391,7 @@ _config_request(struct MPT2SAS_ADAPTER *ioc, Mpi2ConfigRequest_t mpt2sas_base_put_smid_default(ioc, smid); timeleft = wait_for_completion_timeout(&ioc->config_cmds.done, timeout*HZ); - if (!(ioc->config_cmds.status & MPT2_CMD_COMPLETE)) { + if (timeleft == 0 || !(ioc->config_cmds.status & MPT2_CMD_COMPLETE)) { printk(MPT2SAS_ERR_FMT "%s: timeout\n", ioc->name, __func__); _debug_dump_mf(mpi_request, -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists