linux-kernel - Re: [PATCH v2] x86/boot/early_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANCZXo4m-X0ZJG2oU-YABYxTJ6-0+B8eR-UONfcXatzJA=S=Mg@mail.gmail.com>
Date:	Tue, 30 Dec 2014 22:58:29 +0600
From:	Alexander Kuleshov <kuleshovmail@...il.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/boot/early_serial_console: Remove unnecessary check

Do i need to send patch v3 to separate mail thread or add to it?

2014-12-30 21:48 GMT+06:00 Borislav Petkov <bp@...en8.de>:
> On Tue, Dec 30, 2014 at 07:28:22PM +0600, Alexander Kuleshov wrote:
>> There is already the same check before.
>>
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
>> ---
>>  arch/x86/boot/early_serial_console.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
>> index 5df2869..62abcc8 100644
>> --- a/arch/x86/boot/early_serial_console.c
>> +++ b/arch/x86/boot/early_serial_console.c
>> @@ -74,8 +74,7 @@ static void parse_earlyprintk(void)
>>                       static const int bases[] = { 0x3f8, 0x2f8 };
>>                       int idx = 0;
>>
>> -                     if (!strncmp(arg + pos, "ttyS", 4))
>> -                             pos += 4;
>
> You might need a comment to explain the advancing of pos to people who
> look at this in the future, i.e. something like
>
>                         /* += strlen("ttyS"); */
>                         pos += 4;
>>
>>                       if (arg[pos++] == '1')
>>                               idx = 1;
>
> --
> Regards/Gruss,
>     Boris.
> --



-- 
_________________________
0xAX
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/