linux-kernel - Re: [PATCH -rt] timer: upper bound on loops of __run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54A313A0.7050807@redhat.com>
Date:	Tue, 30 Dec 2014 16:05:36 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
CC:	Steven Rostedt <rostedt@...dmis.org>,
	Clark Williams <clark.williams@...il.com>,
	Luiz Capitulino <lcapitulino@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -rt] timer: upper bound on loops of __run_timers processing

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/30/2014 02:52 PM, Marcelo Tosatti wrote:
> 
> Commit "timers: do not raise softirq unconditionally", allows for
> timer wheel processing (__run_timers) to be delayed for long
> periods of time.
> 
> The effect is that
> 
> loops = jiffies - base->timer_jiffies
> 
> Can grow to very large values resulting in __run_timers taking
> hundreds of milliseconds to execute.
> 
> Fix by creating an upper bound on the number of loops to be
> processed. This allows a nohz=off kernel to achieve desired
> latencies.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>
> 
> diff --git a/kernel/timer.c b/kernel/timer.c index f59e18c..c128416
> 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1488,6
> +1488,12 @@ void run_local_timers(void) } #endif
> 
> +	if (time_after_eq(jiffies, base->timer_jiffies)) { +		unsigned
> long jiffies_delta = jiffies - base->timer_jiffies; +		if
> (jiffies_delta > TVR_SIZE) +			raise_softirq(TIMER_SOFTIRQ); +	}

It certainly looks like cascading the timers over and over and
over again could be a lot of work.

Acked-by: Rik van Riel <riel@...hat.com>

- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUoxOfAAoJEM553pKExN6DO+0H/i2TXS2DJ6cObGZytYhsRz/U
4oqH4eCjwK5JczFMsyoUh/kXIkEQukMudj74katoP0TARlcnZF2G+R/Hj4XccCpz
X84DI7SCFZIwl3gpiuOoR81mosd1VkLBouwYj1Aglt+5Sh63yq91lreX20Tw/swF
jlorAWAAblQdt2zC5smjtbbhfKMuPC8qJFGoiGmLLPC/1l9XmGmfymB2WfN8IZm4
DrqAlCSm8+xxGdwUwAZTuHuHX15VOpGuUuEV2E8BM+6G93HI8iJe5E7g5hRymcNp
NPCe+BFgZ9AxHqNokC1cSWrqaS3koBbTJRDKAqxSEptmYQMZ/a61ydYJQmBtImw=
=uqAv
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/