lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Dec 2014 16:14:17 -0500 (EST) From: David Miller <davem@...emloft.net> To: xerofoify@...il.com Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: Question about FIXME in au1xxx-ide.c From: nick <xerofoify@...il.com> Date: Tue, 30 Dec 2014 12:31:04 -0500 > Greetings David, > I am wondering about the fix me in the file,au1xxx-ide.c for > the function,auide_ddma_init. While it's obvious to check the > return code of the function called below the FIXME comment,it > seems to be that there is more to this issue and therefore I > have a few questions. The first being can this device fail and > the system will function properly? The second question being don't > we need to remove the device if the allocation fails in the creation > of the data structures for it's use by the kernel as otherwise aren't > we leaking memory? I have no idea why the FIXME comment is there, I didn't write this driver nor have I ever made any changes to it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists