linux-kernel - Re: [RFC PATCH 0/4] kstrdup optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141230212915.GN2915@two.firstfloor.org>
Date:	Tue, 30 Dec 2014 22:29:16 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Andreas Mohr <andi@...as.de>
Cc:	Andrzej Hajda <a.hajda@...sung.com>,
	Andi Kleen <andi@...stfloor.org>, linux-mm@...ck.org,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/4] kstrdup optimization

> This symmetry issue probably could be cleanly avoided only
> by having kfree() itself contain such an identifying check, as you suggest
> (thereby slowing down kfree() performance).

It actually shouldn't slow it down. kfree already complains if you free
a non slab page, this could be just in front of the error check.

The bigger concern is that it may hide some programing errors elsewhere
though. So it's probably better to keep it a separate function.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/