linux-kernel - Re: [PATCH v3] x86/boot/early_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141230213612.GA9238@pd.tnic>
Date:	Tue, 30 Dec 2014 22:36:12 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] x86/boot/early_serial_console: Remove unnecessary
 check

On Wed, Dec 31, 2014 at 12:18:58AM +0600, Alexander Kuleshov wrote:
> There is already the same check before.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/boot/early_serial_console.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
> index 5df2869..c23bcae 100644
> --- a/arch/x86/boot/early_serial_console.c
> +++ b/arch/x86/boot/early_serial_console.c
> @@ -73,9 +73,8 @@ static void parse_earlyprintk(void)
>  		} else if (!strncmp(arg + pos, "ttyS", 4)) {
>  			static const int bases[] = { 0x3f8, 0x2f8 };
>  			int idx = 0;
> -

You've removed the newline here and we usually do leave an empty line
between the function local variables declarations and the rest of the
function for better readability.

And to answer your question from earlier: yes, if you want to send a
corrected patch, please do send it as a reply to this one.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/