linux-kernel - Re: [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54A325D8.9090902@mev.co.uk>
Date:	Tue, 30 Dec 2014 22:23:20 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	jitendra kumar khasdev <jkhasdev@...il.com>,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
	chase.southwood@...il.com
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: driver : fix max 80 character coding
 style issue in s626.c

On 29/12/14 09:27, jitendra kumar khasdev wrote:
> This is a patch to the s626.c file that fixes up a maximum 80 character limit
> warning found by the checkpatch.pl tool
>
> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@...il.com>
> ---
>   drivers/staging/comedi/drivers/s626.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index fc497dd..77f715b 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
>   	for (i = 0; i < 2; i++) {
>   		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
>   		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
> -		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
> +		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
> +		0);

Technically it meets the requirements, but our comedi house style is to 
indent the continuation of the statement just past the opening 
bracket/parenthesis like so:

		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
				     0);

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/