lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 30 Dec 2014 22:40:11 +0000
From:	Ian Abbott <abbotti@....co.uk>
To:	Andreas Siegling <andreas.siegling@....de>,
	devel@...uxdriverproject.org
CC:	linux-kernel@...cs.fau.de, hsweeten@...ionengravers.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, ebru.akagunduz@...il.com,
	chase.southwood@...il.com, rickard_strandqvist@...ctrumdigital.se,
	Zhutao Lu <lvzhutao@...il.com>
Subject: Re: [PATCH 1/3] comedi: checkpatch error: tabs instead of spaces

On 28/12/14 18:56, Andreas Siegling wrote:
> This patch fixes all occurrences of 8 whitespaces instead of a tab.
> It will remove the 8 whitespaces and replace them with a tab, thereby
> the checkpatch-error:
> 		ERROR: code indent should use tabs where possible
> is removed from all files in drivers/staging/comedi/
> It also brings some consistency of indentation in the comments.
>
> Signed-off-by: Andreas Siegling <andreas.siegling@....de>
> Signed-off-by: Zhutao Lu <lvzhutao@...il.com>
> ---
>   drivers/staging/comedi/drivers/daqboard2000.c | 62 +++++++++++++--------------
>   drivers/staging/comedi/drivers/das16m1.c      |  4 +-
>   drivers/staging/comedi/drivers/dmm32at.c      |  2 +-
>   drivers/staging/comedi/drivers/pcl818.c       | 36 ++++++++--------
>   4 files changed, 52 insertions(+), 52 deletions(-)

Most of these aren't worth doing as they only affect multi-line comments 
that should be reformatted to the usual block comment style anyway.


> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>   	/* enable the ai conversion interrupt and the clock to start scans */
>   	outb(DMM32AT_INTCLK_ADINT |
>   	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>   }
>

That bit of the patch is fine, but has already been tackled in a patch 
by David Decotigny.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists