lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Dec 2014 14:43:30 -0800 From: Jonathan Richardson <jonathar@...adcom.com> To: Tim Kryger <tim.kryger@...il.com> CC: Scott Branden <sbranden@...adcom.com>, Arun Ramamurthy <arun.ramamurthy@...adcom.com>, Thierry Reding <thierry.reding@...il.com>, Ray Jui <rjui@...adcom.com>, <bcm-kernel-feedback-list@...adcom.com>, <linux-kernel@...r.kernel.org>, <linux-pwm@...r.kernel.org>, "Jonathan Richardson" <jonathar@...adcom.com> Subject: [PATCH v4 3/3] pwm: core: Set enable state properly on failed call to enable The pwm_enable function didn't clear the enabled bit if a call to a clients enable function returned an error. The result was that the state of the pwm core was wrong. Clearing the bit when enable returns an error ensures the state is properly set. Signed-off-by: Jonathan Richardson <jonathar@...adcom.com> --- drivers/pwm/core.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 966497d..641f6ec 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -457,8 +457,14 @@ EXPORT_SYMBOL_GPL(pwm_set_polarity); */ int pwm_enable(struct pwm_device *pwm) { - if (pwm && !test_and_set_bit(PWMF_ENABLED, &pwm->flags)) - return pwm->chip->ops->enable(pwm->chip, pwm); + int err; + + if (pwm && !test_and_set_bit(PWMF_ENABLED, &pwm->flags)) { + err = pwm->chip->ops->enable(pwm->chip, pwm); + if (err) + clear_bit(PWMF_ENABLED, &pwm->flags); + return err; + } return pwm ? 0 : -EINVAL; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists