linux-kernel - Re: [PATCH 1/3] CMA: Fix the bug that CMA's page number is substructed twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141230044826.GC4588@js1304-P5Q-DELUXE>
Date:	Tue, 30 Dec 2014 13:48:27 +0900
From:	Joonsoo Kim <iamjoonsoo.kim@....com>
To:	Hui Zhu <zhuhui@...omi.com>
Cc:	m.szyprowski@...sung.com, mina86@...a86.com,
	akpm@...ux-foundation.org, aneesh.kumar@...ux.vnet.ibm.com,
	pintu.k@...sung.com, weijie.yang@...sung.com, mgorman@...e.de,
	hannes@...xchg.org, riel@...hat.com, vbabka@...e.cz,
	laurent.pinchart+renesas@...asonboard.com, rientjes@...gle.com,
	sasha.levin@...cle.com, liuweixing@...omi.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	teawater@...il.com
Subject: Re: [PATCH 1/3] CMA: Fix the bug that CMA's page number is
 substructed twice

On Thu, Dec 25, 2014 at 05:43:26PM +0800, Hui Zhu wrote:
> In Joonsoo's CMA patch "CMA: always treat free cma pages as non-free on
> watermark checking" [1], it changes __zone_watermark_ok to substruct CMA
> pages number from free_pages if system use CMA:
> 	if (IS_ENABLED(CONFIG_CMA) && z->managed_cma_pages)
> 		free_pages -= zone_page_state(z, NR_FREE_CMA_PAGES);

Hello, 

In fact, without that patch, watermark checking has a problem in current kernel.
If there is reserved CMA region, watermark check for high order
allocation is done loosly. See following thread.

https://lkml.org/lkml/2014/5/30/320

Your patch can fix this situation, so, how about submitting this patch
separately?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/