linux-kernel - RE: [PATCH] scsi: unnecessary double init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <058691E078642A44B7C96BB0B1DB4F2481C52A55@avmb2.qlogic.org>
Date:	Wed, 31 Dec 2014 12:40:50 +0000
From:	Nilesh Javali <nilesh.javali@...gic.com>
To:	Nicholas Mc Guire <der.herr@...r.at>,
	"James E.J. Bottomley" <JBottomley@...allels.com>
CC:	Dept-Eng iSCSI Driver <Dept-iSCSIDriver@...gic.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-Eng QLogic Storage Upstream 
	<QLogic-Storage-Upstream@...gic.com>
Subject: RE: [PATCH] scsi: unnecessary double init_completion removed

Acked-by: Nilesh Javali <nilesh.javali@...gic.com>

I will send the maintainer list update patch.

Thanks,
Nilesh

-----Original Message-----
From: Nicholas Mc Guire [mailto:der.herr@...r.at] 
Sent: Tuesday, December 23, 2014 11:30 PM
To: James E.J. Bottomley
Cc: Dept-Eng iSCSI Driver; linux-scsi; linux-kernel; Nicholas Mc Guire
Subject: [PATCH] scsi: unnecessary double init_completion removed

The double call to init_completion(&ha->disable_acb_comp); looks like an editing mistake only - dropped.

patch is against 3.18.0 linux-next

scripts/get_maintainer.pl -f drivers/scsi/qla4xxx/ql4_os.c returned Vikas Chaudhary <vikas.chaudhary@...gic.com> (supporter:QLOGIC QLA4XXX iS...) but that no longer seems to be a valid e-mail address.

Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
---
 drivers/scsi/qla4xxx/ql4_os.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 6d25879..0c1da76 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -8672,7 +8672,6 @@ static int qla4xxx_probe_adapter(struct pci_dev *pdev,
 	init_completion(&ha->disable_acb_comp);
 	init_completion(&ha->idc_comp);
 	init_completion(&ha->link_up_comp);
-	init_completion(&ha->disable_acb_comp);

 	spin_lock_init(&ha->hardware_lock);
 	spin_lock_init(&ha->work_lock);
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/