linux-kernel - Re: [PATCH 1/4] staging: rtl8192u: fix comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141231192842.GC25819@t400>
Date:	Wed, 31 Dec 2014 20:28:42 +0100
From:	Konrad Zapalowicz <bergo.torino@...il.com>
To:	Lorenzo Stoakes <lstoakes@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	gdonald@...il.com, tapaswenipathak@...il.com, yejiayily@...il.com,
	mcgrof@...not-panic.com, anarey@...il.com,
	linux-kernel@...r.kernel.org, rmfrfs@...il.com, joe@...ches.com
Subject: Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 12/31, Lorenzo Stoakes wrote:
> On 31 December 2014 at 19:00, Konrad Zapalowicz <bergo.torino@...il.com> wrote:
> >
> > You also fix the line length here which shall be the subject of a
> > separate patch as this is not C99 comments related change.
> >
> 
> Apologies - I missed this, will prepare a v2 with this separated out
> into a different patch. Relatedly, the intent was to fix whitespace
> issues rather than line length as I gather a specific line length
> limit is still a matter of debate in kernel style? I didn't want to

Usually the kernel people like the line length of 80 characters. There
are exceptions like for example for log messages because it makes easier
to search for it however most of the time 80 is good and whenever
possible it shall be applied.

You can read about it in the
https://www.kernel.org/doc/Documentation/CodingStyle document in second
chapter.

cheers,
konrad

> create additional noise by attempting to address that as well.
> 
> Best, Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/