lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 02 Jan 2015 10:40:04 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Nicholas Krause <xerofoify@...il.com>, stefano.brivio@...imi.it
CC:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	b43-dev@...ts.infradead.org, kvalo@...eaurora.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:net:wireless: Add proper locking for the function,
 b43_op_beacon_set_tim in main.c

On 01/02/2015 01:34 AM, Nicholas Krause wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

Although this patch has already been rejected, I want to comment on the subject 
you have chosen. As you are submitting it to the maintainer of 
drivers/net/wireless/, there is no need to place those entities in the subject. 
A better subject would have been "b43: Add proper locking for 
b43_op_beacon_set_tim()".

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists