linux-kernel - Re: [tpmdd-devel] Question about duplicate definitions of transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150102063649.GB24953@obsidianresearch.com>
Date:	Thu, 1 Jan 2015 23:36:49 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	nick <xerofoify@...il.com>
Cc:	peterhuewe@....de, tpmdd-devel@...ts.sourceforge.net,
	ashley@...leylai.com, linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] Question about duplicate definitions of
 transmit_cmd in tpm-sysfs.c and tmp-interface.c

On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:

> After reading the code and trying various ways to merge these
> functions into tpm.h. I am wondering if the merge is really a good
> idea as it seems to break a lot of code that is very hard to trace
> and redo correctly without a lot of work. Further more I am curious
> as to why the merge is even useful as it seems unneeded to me other
> then to unify the function definitions which seems a minor detail to
> me.

Jarkko has already sent a patch to merge them, I think you can see the
to be merged patch here:

https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4

If you see a problem with it please remark..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/