linux-kernel - Re: [PATCH] staging: rtl8723au: changes stop ap mode to use reset function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150102185639.GA12315@gmail.com>
Date:	Fri, 2 Jan 2015 13:56:39 -0500
From:	Matthew Emerson <emersonmde@...il.com>
To:	Jes Sorensen <Jes.Sorensen@...hat.com>
Cc:	Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723au: changes stop ap mode to use reset
 function

On Fri, Jan 02, 2015 at 10:51:38AM -0500, Jes Sorensen wrote:
> Matthew Emerson <emersonmde@...il.com> writes:
> > Changes stop_ap_mode23a() to use rtw_reset_securitypriv23a. This makes
> > the code cleaner and fixes two checkpatch.pl errors, one line over 80
> > characters, and one spacing issue.
> >
> > Signed-off-by: Matthew Emerson <emersonmde@...il.com>
> > ---
> >  drivers/staging/rtl8723au/core/rtw_ap.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> > index e394d12c36b0..510ee212496f 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> > @@ -1870,10 +1870,8 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> >  	pmlmepriv->update_bcn = false;
> >  	pmlmeext->bstart_bss = false;
> >  
> > -	/* reset and init security priv , this can refine with rtw_reset_securitypriv23a */
> > -	memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv));
> > -	padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeOpen;
> > -	padapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
> > +	/* reset and init security priv */
> > +	rtw_reset_securitypriv23a(padapter);
> 
> This is broken, rtw_reset_securitypriv23a() takes different actions
> based on the value of adapter->securitypriv.dot11AuthAlgrthm - you leave
> it at it's old value, which does not have the same effect as the above.
> 
> If anything you should remove the memset() and call
> rtw_reset_securitypriv23a() after the two assignments.
> 
> NACK
> 
> Jes

Thank you for you feedback! I had noticed that the two assignments above
(for .ndisauthtype and .ndisencryptstatus) take place in both branches
of the if statement in rtw_reset_securitypriv23a() so I thought removing
them here would be okay. I'll be sure to make the changes you suggested.

Thanks for your time,
Matthew Emerson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/