[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150102201426.GA15696@neon.local.cohere.net>
Date: Fri, 2 Jan 2015 12:14:26 -0800
From: Insop Song <insop.song@...nspeed.com>
To: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
Paul Bolle <pebolle@...cali.nl>,
Monam Agarwal <monamagarwal123@...il.com>,
MichaĆ Bartoszkiewicz
<mbartoszkiewicz@...il.com>, Rocco Folino <lordzen87@...il.com>,
<devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function
Reviewed-by: Insop Song <Insop.Song@...nspeed.com>
Thank you,
ISS
On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote:
> Remove the function bitswap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
> drivers/staging/gs_fpgaboot/io.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.c
> index b260e45..819db53 100644
> --- a/drivers/staging/gs_fpgaboot/io.c
> +++ b/drivers/staging/gs_fpgaboot/io.c
> @@ -79,15 +79,6 @@ void xl_shift_bytes_out(enum wbus bus_byte, unsigned char *pdata)
> /*
> * generic bit swap for xilinx SYSTEMMAP FPGA programming
> */
> -static inline unsigned char bitswap(unsigned char s)
> -{
> - unsigned char d;
> -
> - d = (((s&0x80)>>7) | ((s&0x40)>>5) | ((s&0x20)>>3) | ((s&0x10)>>1) |
> - ((s&0x08)<<1) | ((s&0x04)<<3) | ((s&0x02)<<5) | ((s&0x01)<<7));
> - return d;
> -}
> -
> void xl_program_b(int32_t i)
> {
> }
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists