linux-kernel - Re: [PATCH] sound: drivers: portman2x4.c: Remove some unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hfvbtfvg7.wl-tiwai@suse.de>
Date:	Fri, 02 Jan 2015 09:17:12 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: drivers: portman2x4.c:  Remove some unused functions

At Thu,  1 Jan 2015 16:12:45 +0100,
Rickard Strandqvist wrote:
> 
> Removes some functions that are not used anywhere:
> portman_read_data() portman_read_command()
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  sound/drivers/portman2x4.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
> index 78ccfa4..b5b6b4e 100644
> --- a/sound/drivers/portman2x4.c
> +++ b/sound/drivers/portman2x4.c
> @@ -198,21 +198,11 @@ static inline void portman_write_command(struct portman *pm, u8 value)
>  	parport_write_control(pm->pardev->port, value);
>  }
>  
> -static inline u8 portman_read_command(struct portman *pm)
> -{
> -	return parport_read_control(pm->pardev->port);
> -}
> -
>  static inline u8 portman_read_status(struct portman *pm)
>  {
>  	return parport_read_status(pm->pardev->port);
>  }
>  
> -static inline u8 portman_read_data(struct portman *pm)
> -{
> -	return parport_read_data(pm->pardev->port);
> -}
> -
>  static inline void portman_write_data(struct portman *pm, u8 value)
>  {
>  	parport_write_data(pm->pardev->port, value);

Rickard, your works are highly appreciated, but please think twice
before submitting patches: is it worth for the whole?

For example, in this case: the removals are static inline functions.
So there is no gain by removing this regarding the object size.  OTOH, 
they are obviously wrapper accessors, thus dropping blindly would
result in inconsistency.  That is, a reader may wonder later why some
are write only and some not.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/