linux-kernel - [PATCH 0/3 RFC] Coccinelle: completion API checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1420192752-4889-1-git-send-email-der.herr@hofr.at>
Date:	Fri,  2 Jan 2015 04:59:09 -0500
From:	Nicholas Mc Guire <der.herr@...r.at>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Michal Marek <mmarek@...e.cz>,
	Andreas Platschek <platschek@....tuwien.ac.at>,
	cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org
Subject: [PATCH 0/3 RFC] Coccinelle: completion API checking


This little set of semantic patches is for partially checking the
completion API. It seems to be working correctly and has not yet
produced any false-positive.

The cases being detected are:

1/3 - duplicate init_completions.
2/3 - incorrect static initialization of completion on stack.
3/3 - re-initialization of completion with init_completion() rather
      than reinit_completion().

semantic patch                  findings   files  confirmed
duplicate_init_completion.cocci    2         2        2
false_declare_completion.cocci     6         5        3 
false_init_compltion.cocci         9         6        5 

Note: false_declare_completion.cocci runs extremely slow on my system
      roughly a factor 10 slower than the other two - not clear why.

All findings have been submitted based on these scripts. Some have 
not yet been confirmed.

Note sure if it makes sense putting this type of API misuse cleanup
into mainline given the relatively small number of findings.

patch is against linux-next 3.19.0-rc1 (-next-20141226)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/