linux-kernel - [PATCH] Documentation: dell-laptop: correct als

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1420196810-8855-1-git-send-email-gabriele.mzt@gmail.com>
Date:	Fri,  2 Jan 2015 12:06:50 +0100
From:	Gabriele Mazzotta <gabriele.mzt@...il.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	dvhart@...ux.intel.com, pali.rohar@...il.com,
	computersforpeace@...il.com, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org, A.Sloman@...bham.ac.uk,
	Gabriele Mazzotta <gabriele.mzt@...il.com>
Subject: [PATCH] Documentation: dell-laptop: correct als_setting description

It was incorrectly stated that als_setting is to enable and disable
the ambient light sensor on supported system rather than setting a
threshold value. Correct the description and add a note to make more
clear what could be the effect of changing als_setting.

Reported-by: Brian Norris <computersforpeace@...il.com>
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
---
 Documentation/ABI/testing/sysfs-platform-dell-laptop | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-platform-dell-laptop b/Documentation/ABI/testing/sysfs-platform-dell-laptop
index 7969443..a40c217 100644
--- a/Documentation/ABI/testing/sysfs-platform-dell-laptop
+++ b/Documentation/ABI/testing/sysfs-platform-dell-laptop
@@ -4,10 +4,12 @@ KernelVersion:	3.19
 Contact:	Gabriele Mazzotta <gabriele.mzt@...il.com>,
 		Pali Rohár <pali.rohar@...il.com>
 Description:
-		This file allows to control the automatic keyboard
-		illumination mode on some systems that have an ambient
-		light sensor. Write 1 to this file to enable the auto
-		mode, 0 to disable it.
+		This file allows to set at which value reported by the
+		ambient light sensor the keyboard backlight has to be
+		turned on or off.
+
+		Note that the 'als' trigger must be supported and enabled
+		for this setting to have any effect.
 
 What:		/sys/class/leds/dell::kbd_backlight/start_triggers
 Date:		December 2014
@@ -32,6 +34,13 @@ Description:
 
 		Note that not all the available triggers can be configured.
 
+		Note also that enabling the 'als' trigger could simply
+		alter the behavior of the other triggers and not allow
+		the ambient light sensor control the keyboard illumination
+		independently. It could prevent other triggers from turning
+		the keyboard backlight on or force them to turn it off
+		depending on the current ambient light and als_setting.
+
 What:		/sys/class/leds/dell::kbd_backlight/stop_timeout
 Date:		December 2014
 KernelVersion:	3.19
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/