linux-kernel - Re: [PATCH] media: platform: vsp1: vsp1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3534952.jhm28o5kMm@avalon>
Date:	Fri, 02 Jan 2015 14:09:58 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	linux-media@...r.kernel.org
Cc:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: platform: vsp1: vsp1_hsit:  Remove unused function

Hi Rickard,

Thank you for the patch.

On Thursday 01 January 2015 18:51:30 Rickard Strandqvist wrote:
> Remove the function vsp1_hsit_read() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

I've taken the patch in my tree and will send a pull request for v3.20.

> ---
>  drivers/media/platform/vsp1/vsp1_hsit.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_hsit.c
> b/drivers/media/platform/vsp1/vsp1_hsit.c index db2950a..9fb003b 100644
> --- a/drivers/media/platform/vsp1/vsp1_hsit.c
> +++ b/drivers/media/platform/vsp1/vsp1_hsit.c
> @@ -26,11 +26,6 @@
>   * Device Access
>   */
> 
> -static inline u32 vsp1_hsit_read(struct vsp1_hsit *hsit, u32 reg)
> -{
> -	return vsp1_read(hsit->entity.vsp1, reg);
> -}
> -
>  static inline void vsp1_hsit_write(struct vsp1_hsit *hsit, u32 reg, u32
> data) {
>  	vsp1_write(hsit->entity.vsp1, reg, data);

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/