linux-kernel - Re: [PATCH] arch: avr32: mach-at32ap: at32ap700x: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150102132106.GA8951@samfundet.no>
Date:	Fri, 2 Jan 2015 14:21:06 +0100
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Haavard Skinnemoen <hskinnemoen@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: avr32: mach-at32ap: at32ap700x:  Remove unused
 function

Around Thu 01 Jan 2015 18:52:22 +0100 or thereabout, Rickard Strandqvist wrote:
> Remove the function set_ebi_sfr_bits() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Hmmm, nack, I suspect there was non-upstreamed boards that used this to
fiddle with the hmatrix. I even think Atmel still has an appnote about how to
do this.

At least NGW100 was used to verify that fiddling with hmatrix worked.

> ---
>  arch/avr32/mach-at32ap/at32ap700x.c |   11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
> index 37b7560..d84516c 100644
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -744,17 +744,6 @@ struct clk at32_hmatrix_clk = {
>  	.users		= 1,
>  };
>  
> -/*
> - * Set bits in the HMATRIX Special Function Register (SFR) used by the
> - * External Bus Interface (EBI). This can be used to enable special
> - * features like CompactFlash support, NAND Flash support, etc. on
> - * certain chipselects.
> - */
> -static inline void set_ebi_sfr_bits(u32 mask)
> -{
> -	hmatrix_sfr_set_bits(HMATRIX_SLAVE_EBI, mask);
> -}
> -
>  /* --------------------------------------------------------------------
>   *  Timer/Counter (TC)
>   * -------------------------------------------------------------------- */
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/