| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <54A83B80.1020508@ti.com> Date: Sat, 03 Jan 2015 12:57:04 -0600 From: Nishanth Menon <nm@...com> To: Pavel Machek <pavel@....cz>, linux-omap@...r.kernel.org CC: edubezval@...il.com, rui.zhang@...el.com, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org Subject: Re: [PATCH] cleanup ti-soc-thermal On 01/03/2015 12:51 PM, Pavel Machek wrote: > On Sat 2015-01-03 11:48:04, Nishanth Menon wrote: >> On 12:19-20150103, Pavel Machek wrote: >>> Simplify code by removing goto's where they point to simple return. >>> >>> Avoid confusing |= on error values. >> >> Please split these up into chunks of related changes. there is white >> space and quiet a few other changes all mixed in. > > Do you believe that the patch is too big to be understood? I don't > think it is. > > It is four screens, and it is pretty obvious it does not change any > code. It basic patch generation stuff - where you are being nice to the reviewer. When you are doing functional changes, at least drop out or at the very least mention that there are white space changes in your patch submission. I dont care too much to review stuff where I have to look at multiple changes in a single patch - trivial or not. Sorry.. just a waste of my time. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists