linux-kernel - Re: [PATCH] thermal: add omap3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 3 Jan 2015 23:02:19 +0100
From:	Pavel Machek <pavel@....cz>
To:	Eduardo Valentin <edubezval@...il.com>, nm@...com
Cc:	rui.zhang@...el.com, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, pali.rohar@...il.com, sre@...ian.org,
	sre@...g0.de,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap@...r.kernel.org, tony@...mide.com, khilman@...nel.org,
	aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com
Subject: Re: [PATCH] thermal: add omap3 support

Hi!

> Thanks for sending your code.

You are welcome.

> > Add support for omap3430 sensor. Tested on Nokia N900.
> 
> To my understanding, and as already mentioned by Nishanth Menon
> (currently TIer), TI has intentionally avoided adding this support.

Well, Nokia had similar code in their kernel.

> There is a hardware accuracy limitation in this sensor, and therefore it
> is not advisable to use it, specially in Dynamic Thermal Management,
> such as the thermal framework.

We are talking cellphone here. Yes, sensor may be inacurate (but it
seems to work pretty well; perhaps TI can point us to some docs that
explains the details?), but it provides useful information (mostly
room temperature). I don't think we'll ever run anywhere close to
thermal limits where inacuracy would matter. (Battery can't really
take > 60C. AFAICT CPU limit is 120C. Battery is close to the CPU.)

> > Signed-off-by: Pavel Machek <pavel@....cz>
> > 
> > diff --git a/drivers/thermal/ti-soc-thermal/Kconfig b/drivers/thermal/ti-soc-thermal/Kconfig
> > index bd4c7be..a49495f 100644
> > --- a/drivers/thermal/ti-soc-thermal/Kconfig
> > +++ b/drivers/thermal/ti-soc-thermal/Kconfig
> > @@ -21,6 +21,15 @@ config TI_THERMAL
> >  	  This includes trip points definitions, extrapolation rules and
> >  	  CPU cooling device bindings.
> >  
> > +config OMAP3_THERMAL
> > +	bool "Texas Instruments OMAP3 thermal support"
> > +	depends on TI_SOC_THERMAL
> > +	depends on ARCH_OMAP3
> > +	help
> > +	  If you say yes here you get thermal support for the Texas Instruments
> > +	  OMAP3 SoC family. The current chip supported are:
> > +	   - OMAP3430
> 
> But if you insist :-), I believe the user deserves at least a fair
> message saying this is on his / her own risk.

Something like this?

          If you say yes here you get thermal support for the Texas Instruments
	  OMAP3 SoC family. The current chip supported are:
	              - OMAP3430

          OMAP3 chips normally don't need thermal management, and sensors in
	  this generation are not very accurate, nor they are very close to
          the important hotspots.

          Say 'N' here.
	  

> > +static struct temp_sensor_registers
> > +omap34xx_mpu_temp_sensor_registers = {
> > +	.temp_sensor_ctrl = 0,
> > +	.bgap_tempsoff_mask = 0, /* Unused, we don't have POWER_SWITCH */
> > +	.bgap_soc_mask = BIT(8),
> > +	.bgap_eocz_mask = BIT(7),
> > +	.bgap_dtemp_mask = 0x7f,
> > +
> > +	.bgap_mode_ctrl = 0,
> > +	.mode_ctrl_mask = BIT(9),
> > +
> > +	.bgap_efuse = 0,
> 
> The 0'ed filed may be removed here.

Ok; I'll keep temp_sensors_ctrl / bgap_mode_ctrl, because it is actually used.


> > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > index 634b6ce..3b4e72f 100644
> > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> > @@ -1509,6 +1531,12 @@ static SIMPLE_DEV_PM_OPS(ti_bandgap_dev_pm_ops, ti_bandgap_suspend,
> >  #endif
> >  
> >  static const struct of_device_id of_ti_bandgap_match[] = {
> > +#ifdef CONFIG_OMAP3_THERMAL
> > +	{
> > +		.compatible = "ti,omap34xx-bandgap",
> 
> This needs to be updated in the binding documentation.
> Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt

Ok.

> > +		.data = (void *)&omap34xx_data,
> 
> 
> Having a run time message intentionally advising users of the risk of
> using this sensor is also required.

Ok, what about?

    if (TI_BANDGAP_HAS(bgp, UNRELIABLE))
              dev_warn(&pdev->dev,
                         "OMAP3 thermal sensor is unreliable and normally unneccessary\n");

Will not fit in 80 columns, but keeping message on one line is more important.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/