linux-kernel - Re: [PATCH v2] x86,setup: Rename myisspace to isspace and move it to ctype.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150103120520.GB30723@pd.tnic>
Date:	Sat, 3 Jan 2015 13:05:20 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86,setup: Rename myisspace to isspace and move it to
 ctype.h

On Sat, Jan 03, 2015 at 01:10:05PM +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/boot/cmdline.c | 19 +++++++------------
>  arch/x86/boot/ctype.h   |  5 +++++
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/x86/boot/cmdline.c b/arch/x86/boot/cmdline.c
> index 625d21b..bc1e25f 100644
> --- a/arch/x86/boot/cmdline.c
> +++ b/arch/x86/boot/cmdline.c
> @@ -14,11 +14,6 @@
>  
>  #include "boot.h"
>  
> -static inline int myisspace(u8 c)
> -{
> -	return c <= ' ';	/* Close enough approximation */
> -}
> -

This is called myisspace on purpose so that it doesn't get confused with
the libc version. This patch is unnecessary IMO.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/