linux-kernel - Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 4 Jan 2015 20:43:23 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Pavel Machek <pavel@....cz>,
	Marc Zyngier <marc.zyngier@....com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix
 pyaudio (and probably more)

On Sun, Jan 04, 2015 at 12:22:36PM -0800, Linus Torvalds wrote:
> On Sun, Jan 4, 2015 at 12:03 PM, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
> >
> > NAK.
> 
> To quote the standard response for people who ignore regressions:
> 
>   "SHUT THE FUCK UP"
> 
> you cannot NAK regression fixes. Seriously.

How about we calm down and take some informed view instead of throwing
mud?  I'd never thought I'd have to be doing this but it seems necessary.

Yes, it's bad that we now have a userspace breakage from removing the
bogomips, but a simple revert of the patch doesn't fix it properly.  It
_may_ seem to get things going again by providing a value, but that
value may not be what was once provided back in the days that these
programs were written.

The problem is that we now have hardware timers providing the kernel's
delay implementation, which makes the published "bogomips" value no
longer meaningful for the CPU speed.

So, merely reverting the patch doesn't fix the problem.  So, Nico's
NAK on the simple revert is quite right.

Instead of throwing insults, what we need to do is to approach this
calmly, and work out what we can do to fix it properly.

I'm *not* going to be looking at this until at least mid-week because
I'm still on my Christmas break, but also I'm unwell which has left me
severely lacking sleep.  If others want to do all the necessary
research, then be my guest.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/