linux-kernel - Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150104205214.GA32421@amd>
Date:	Sun, 4 Jan 2015 21:52:14 +0100
From:	Pavel Machek <pavel@....cz>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Nicolas Pitre <nicolas.pitre@...aro.org>,
	Marc Zyngier <marc.zyngier@....com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix
 pyaudio (and probably more)

On Sun 2015-01-04 20:43:23, Russell King - ARM Linux wrote:
> On Sun, Jan 04, 2015 at 12:22:36PM -0800, Linus Torvalds wrote:
> > On Sun, Jan 4, 2015 at 12:03 PM, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
> > >
> > > NAK.
> > 
> > To quote the standard response for people who ignore regressions:
> > 
> >   "SHUT THE FUCK UP"
> > 
> > you cannot NAK regression fixes. Seriously.
> 
> How about we calm down and take some informed view instead of throwing
> mud?  I'd never thought I'd have to be doing this but it seems necessary.
> 
> Yes, it's bad that we now have a userspace breakage from removing the
> bogomips, but a simple revert of the patch doesn't fix it properly.  It
> _may_ seem to get things going again by providing a value, but that
> value may not be what was once provided back in the days that these
> programs were written.

It is the value we had there in 2013, and it seems to be close enough
to value userspace expects there. It is certainly safer/better/closer
than "1.0" Nicolas proposes.

> So, merely reverting the patch doesn't fix the problem.  So, Nico's
> NAK on the simple revert is quite right.

> Instead of throwing insults, what we need to do is to approach this
> calmly, and work out what we can do to fix it properly.

Looking at 9fc2105aeaaf56b0cf75296a84702d0f9e64437b's changelog, I'd
say that insults are not out of place.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/