linux-kernel - [PATCH RFC] usb: chipidea: add support for usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1f6e0195fcb215d8378db66bdd67900e57b9d290.1420351491.git.baruch@tkos.co.il>
Date:	Sun,  4 Jan 2015 08:28:32 +0200
From:	Baruch Siach <baruch@...s.co.il>
To:	Felipe Balbi <balbi@...com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Peter Chen <Peter.Chen@...escale.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	Baruch Siach <baruch@...s.co.il>
Subject: [PATCH RFC] usb: chipidea: add support for usb_phy in generic usb2

Signed-off-by: Baruch Siach <baruch@...s.co.il>
---
 drivers/usb/chipidea/ci_hdrc_usb2.c | 5 +++++
 1 file changed, 5 insertions(+)

I'm sending this as RFC as I'm not sure this is the right thing to do. There
seems to be a move away from USB specific PHY drivers towards the generic PHY
framework (drivers/phy). The trouble is that my PHY is similar to the mxs PHY
(phy-mxs-usb.c), and like mxs I need the notify_connect/notify_disconnect
callbacks. This functionality is not available is the generic PHY
framework. Having support for both 'usb-phy' and 'phy' properties (as dwc3
seems to do) is particularly bad, since the distinction between the two is a
Linux implementation detail that has nothing to do with hardware description.

So my questions are:

   1. Is there a plan to add notifications support to the generic PHY?

   2. If not, what are my options?

Thanks,
baruch

diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 45844c951788..cc3aeb781a57 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -35,11 +35,16 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct ci_hdrc_usb2_priv *priv;
 	struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(dev);
+	struct usb_phy *usb_phy;
 	int ret;

 	if (!ci_pdata)
 		ci_pdata = &ci_default_pdata;

+	usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0);
+	if (!IS_ERR(usb_phy))
+		ci_pdata->usb_phy = usb_phy;
+
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/