linux-kernel - Re: [PATCH v3] irqchip: gic: Allow interrupt level to be set for PPIs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150105013656.GA3486@titan.lakedaemon.net>
Date:	Sun, 4 Jan 2015 20:36:56 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Liviu Dudau <Liviu.Dudau@....com>
Cc:	Russell King <linux@....linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <Mark.Rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Marc Zyngier <Marc.Zyngier@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3] irqchip: gic: Allow interrupt level to be set for
 PPIs.

On Tue, Dec 09, 2014 at 12:29:19PM +0000, Liviu Dudau wrote:
> On Mon, Dec 01, 2014 at 12:45:09PM +0000, Liviu Dudau wrote:
> > During a recent cleanup of the arm64 DTs it has become clear that
> > the handling of PPIs in xxxx_set_type() is incorrect. The ARM TRMs
> > for GICv2 and later allow for "implementation defined" support for
> > setting the edge or level type of the PPI interrupts and don't restrict
> > the activation level of the signal. Current ARM implementations
> > do restrict the PPI level type to IRQ_TYPE_LEVEL_LOW, but licensees
> > of the IP can decide to shoot themselves in the foot at any time.
> > 
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>
> > ---
> > 
> > Made a stupid mistake in v2 and got my bit test confused with logical test.
> 
> Gentle ping!
> 
> Any comments here? Russell, are you OK with this approach?

Now that the holidays are over, I'd like to get some feedback from Marc
at a minimum...

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/