lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Jan 2015 10:37:26 +0900 From: Joonsoo Kim <iamjoonsoo.kim@....com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org, Jesper Dangaard Brouer <brouer@...hat.com> Subject: [PATCH 1/6] mm/slab: fix gfp flags of percpu allocation at boot phase __alloc_percpu() passed GFP_KERNEL implicitly to core function of percpu allocator. At boot phase, it's not valid gfp flag so change it. Without this change, while implementing new feature, I found that __alloc_percpu() calls kmalloc() which is not initialized at this time and the system fail to boot. percpu allocator regards GFP_KERNEL as the sign of the system fully initialized so aggressively try to make spare room. With GFP_NOWAIT, it doesn't do that so succeed to boot. Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com> --- mm/slab.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/slab.c b/mm/slab.c index 65b5dcb..1150c8b 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -1990,9 +1990,12 @@ static struct array_cache __percpu *alloc_kmem_cache_cpus( int cpu; size_t size; struct array_cache __percpu *cpu_cache; + gfp_t gfp_flags = GFP_KERNEL; size = sizeof(void *) * entries + sizeof(struct array_cache); - cpu_cache = __alloc_percpu(size, sizeof(void *)); + if (slab_state < FULL) + gfp_flags = GFP_NOWAIT; + cpu_cache = __alloc_percpu_gfp(size, sizeof(void *), gfp_flags); if (!cpu_cache) return NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists