lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 5 Jan 2015 21:31:59 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stephan Mueller <smueller@...onox.de>
Cc:	Daniel Borkmann <dborkman@...hat.com>,
	'Quentin Gouchet' <quentin.gouchet@...il.com>,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	ABI/API <linux-api@...r.kernel.org>
Subject: Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support

On Fri, Jan 02, 2015 at 03:41:33PM +0100, Stephan Mueller wrote:
>
> +		if (!con.aead_assoclen)
> +			return -EINVAL;

AD being zero should be fine.

> +		/* aead_recvmsg limits the maximum AD size to one page */
> +		if (con.aead_assoclen > PAGE_SIZE)
> +			return -E2BIG;

I don't see any need to limit the size of the AD.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists