linux-kernel - Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 04 Jan 2015 19:40:41 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
CC:	Joe Perches <joe@...ches.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch

On 01/04/2015 01:10 AM, Joe Perches wrote:
> On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> []
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> []
>> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
>>   		dm_digtable.rssi_low_thresh = dm_value;
>>   	} else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>>   		dm_digtable.rssi_high_power_highthresh = dm_value;
>> -	} else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> +	} else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
>>   		dm_digtable.rssi_high_power_highthresh = dm_value;
>>   	} else if (dm_type == DIG_TYPE_ENABLE) {
>>   		dm_digtable.dig_state		= DM_STA_DIG_MAX;
>
> Presumably, this is a copy/paste error and should have
> both lines changed to HIGHPWR_LOW/high_power_lowthresh
>
> 	else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
> 		dm_digtable.rssi_high_power_lowthresh = dm_value;
>

I have no idea what this should be, but this patch does not appear to be any 
improvement. Joe is probably correct.

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/